pgadmin: 8.1 -> 8.2, python3Packages.webauthn 1.11.1 -> 2.0.0, python3Packages.flask-security-too: fix pydantic issue by gador · Pull Request #280556 · NixOS/nixpkgs

gador · 2024-01-12T18:43:03Z

Description of changes

This is a major update to pgadmin. (https://www.pgadmin.org/docs/pgadmin4/latest/release_notes_8_2.html)
Mainly, a new cli option has been added.
Due to the change, we can drop most of our expose-setup patch.

Required changes to other packages

webauthn has been updated to version 2. This is a major release (See https://github.com/duo-labs/py_webauthn/blob/master/CHANGELOG.md). No new build failures have been detected, though.
flask-security-too can drop the pydantic broken flag, since webauthn has dropped pydantic. This did require an (already merged) patch from upstream

Updating webauthn is a more elegant solution IMHO than overwriting pydantic version in pgadmin and also fixes the until-now broken flask-security-too.

Things done

Module tested successfully in a VM.

Add a 👍 reaction to pull requests you find important.

mkg20001 · 2024-01-12T20:53:17Z

@ofborg test pgadmin

mkg20001 · 2024-01-12T21:03:50Z

@ofborg test pgadmin4

gador · 2024-01-12T21:24:54Z

I rebased on current master and found an error, since flask-security-too was marked as broken. This was due to a recent merge of #271586 (and specifically 5fa3852).
I added a fix to use the older version of pydantic and it should evaluate now

gador · 2024-01-12T22:13:12Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 280556 run on x86_64-linux 1

1 package blacklisted:

nixos-install-tools

4 packages failed to build and are new build failures:

irrd: log was empty
irrd.dist: log was empty
python312Packages.webauthn: log was empty
python312Packages.webauthn.dist: log was empty

8 packages built:

pgadmin4
pgadmin4-desktopmode
pgadmin4-desktopmode.dist
pgadmin4.dist
python311Packages.flask-security-too
python311Packages.flask-security-too.dist
python311Packages.webauthn
python311Packages.webauthn.dist

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

Details

python311Packages.webauthn.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/mvxadj9c2zyspkn2rl3dhx8js5lghcv0-python3.11-webauthn-1.11.1-dist' from 'daemon'
When evaluating attribute ‘python311Packages.webauthn.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/webauthn/default.nix:53:5:

   |
53 |     maintainers = with maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.webauthn:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

got build log for '/nix/store/2lvwkf61pb6v7ds42imds2g0js8b2fpd-python3.11-webauthn-1.11.1' from 'daemon'
When evaluating attribute ‘python311Packages.webauthn’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/webauthn/default.nix:53:5:

   |
53 |     maintainers = with maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.webauthn.dist:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/webauthn/default.nix:53:5:

   |
53 |     maintainers = with maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.webauthn:

Package is missing maintainers.
If the package is using runCommand please make sure to inherit or list one or more maintainers.

warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/webauthn/default.nix:53:5:

   |
53 |     maintainers = with maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

gador · 2024-01-12T22:19:35Z

Failure in irrd is due to a failure in the build dependency python3Packages.ariadne which seems unrelated to changes made in this PR:

E       AssertionError: assert <snapshottest.pytest.PyTestSnapshotTest object at 0x7fffdf81a110> == [b'Request body cannot be empty']

is a recurring error.

Failure in python312Packages.webauthn seems to stem from a build failure of python3.12-pydantic-1.10.13. My guess is pydantic_1 isn't compatible with python 3.12:


pydantic>         with pytest.raises(TypeError, match=message):
pydantic> >           Foobar()
pydantic> E           TypeError: Can't instantiate abstract class Foobar without an implementation for abstract method 'get_secret_value'
pydantic>
pydantic> tests/test_types.py:2719: TypeError
pydantic>
pydantic> During handling of the above exception, another exception occurred:
pydantic>
pydantic>     def test_secretfield():
pydantic>         class Foobar(SecretField):
pydantic>             ...
pydantic>
pydantic>         message = "Can't instantiate abstract class Foobar with abstract methods? get_secret_value"
pydantic>
pydantic> >       with pytest.raises(TypeError, match=message):
pydantic> E       AssertionError: Regex pattern did not match.
pydantic> E        Regex: "Can't instantiate abstract class Foobar with abstract methods? get_secret_value"
pydantic> E        Input: "Can't instantiate abstract class Foobar without an implementation for abstract method 'get_secret_value'"

are the last two of four test failures.

gador · 2024-01-13T06:47:49Z

@ofborg test pgadmin4

Signed-off-by: Florian Brandes <florian.brandes@posteo.de>

gador · 2024-01-13T10:00:02Z

This is a semi-automatic executed nixpkgs-review with nixpkgs-review-checks extension. It is checked by a human on a best effort basis and does not build all packages (e.g. lumo, tensorflow or pytorch).

Result of nixpkgs-review pr 280556 run on x86_64-linux 1

1 package blacklisted:

nixos-install-tools

2 packages failed to build and are new build failures:

irrd: log was empty
irrd.dist: log was empty

10 packages built:

pgadmin4
pgadmin4-desktopmode
pgadmin4-desktopmode.dist
pgadmin4.dist
python311Packages.flask-security-too
python311Packages.flask-security-too.dist
python311Packages.webauthn
python311Packages.webauthn.dist
python312Packages.webauthn
python312Packages.webauthn.dist

The following issues got detected with the above build packages.
Please fix at least the ones listed with your changed packages:

Details

python311Packages.webauthn.dist:

error: build log of '/nix/store/65wn121xx63bk5d00f3v2bp42zjml60m-python3.11-webauthn-2.0.0-dist' is not available
When evaluating attribute ‘python311Packages.webauthn.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/webauthn/default.nix:49:5:

   |
49 |     maintainers = with maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python311Packages.webauthn:

error: build log of '/nix/store/mnf64a1fx5qmd1n4s3lz6m1z9byraic1-python3.11-webauthn-2.0.0' is not available
When evaluating attribute ‘python311Packages.webauthn’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/webauthn/default.nix:49:5:

   |
49 |     maintainers = with maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.webauthn.dist:

error: build log of '/nix/store/6ccpz5hjcq54ac1w4wvfwmvfmlnyrwzb-python3.12-webauthn-2.0.0-dist' is not available
When evaluating attribute ‘python312Packages.webauthn.dist’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/webauthn/default.nix:49:5:

   |
49 |     maintainers = with maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

python312Packages.webauthn:

error: build log of '/nix/store/kyzm0skh9dr1860fj3mnpd18fca3n944-python3.12-webauthn-2.0.0' is not available
When evaluating attribute ‘python312Packages.webauthn’:
warning: maintainers-missing
Package does not have a maintainer. Consider adding yourself?

Near pkgs/development/python-modules/webauthn/default.nix:49:5:

   |
49 |     maintainers = with maintainers; [ ];
   |     ^

See: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/maintainers-missing.md

risicle · 2024-01-13T16:06:17Z

@ofborg build irrd

Fails for me

gador · 2024-01-13T16:58:51Z

@ofborg build irrd

Fails for me

yes, fails on master, too

gador · 2024-01-13T16:59:34Z

@ofborg test pgadmin4

nixos/tests/pgadmin4.nix

pkgs/development/python-modules/flask-security-too/default.nix

also removes pydantic (since webauth 2 doesn't use it anymore) Signed-off-by: Florian Brandes <florian.brandes@posteo.de> Co-authored-by: Sandro <sandro.jaeckel@gmail.com>

gador requested a review from mkg20001 January 12, 2024 18:43

github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 12, 2024

mkg20001 approved these changes Jan 12, 2024

View reviewed changes

delroth added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 12, 2024

gador force-pushed the pgadmin-8.2 branch from b5d3533 to a6b78b3 Compare January 12, 2024 21:16

github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 12, 2024

gador force-pushed the pgadmin-8.2 branch from a6b78b3 to 9b8ac61 Compare January 12, 2024 21:24

delroth removed the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 12, 2024

gador marked this pull request as draft January 13, 2024 08:34

gador force-pushed the pgadmin-8.2 branch from 123f596 to ad62395 Compare January 13, 2024 08:53

gador added 2 commits January 13, 2024 09:54

pgadmin: 8.1 -> 8.2

1c1ca56

Signed-off-by: Florian Brandes <florian.brandes@posteo.de>

python3Packages.webauthn: 1.11.1 -> 2.0.0

c2eb991

Signed-off-by: Florian Brandes <florian.brandes@posteo.de>

gador force-pushed the pgadmin-8.2 branch from ad62395 to ea01ea2 Compare January 13, 2024 08:54

gador marked this pull request as ready for review January 13, 2024 10:00

gador changed the title ~~pgadmin: 8.1 -> 8.2~~ pgadmin: 8.1 -> 8.2, python3Packages.webauthn 1.11.1 -> 2.0.0, python3Packages.flask-security-too: fix pydantic issue Jan 13, 2024

SuperSandro2000 approved these changes Jan 15, 2024

View reviewed changes

nixos/tests/pgadmin4.nix Outdated Show resolved Hide resolved

pkgs/development/python-modules/flask-security-too/default.nix Outdated Show resolved Hide resolved

pkgs/development/python-modules/flask-security-too/default.nix Outdated Show resolved Hide resolved

delroth added the 12.approvals: 2 This PR was reviewed and approved by two persons. label Jan 15, 2024

python3Packages.flask-security-too: fix for webauth 2

03649bf

also removes pydantic (since webauth 2 doesn't use it anymore) Signed-off-by: Florian Brandes <florian.brandes@posteo.de> Co-authored-by: Sandro <sandro.jaeckel@gmail.com>

gador force-pushed the pgadmin-8.2 branch from cc63b57 to 03649bf Compare January 16, 2024 14:55

gador mentioned this pull request Jan 16, 2024

python3Packages.flask-security-too: fix build failure #192456

Merged

13 tasks

mkg20001 approved these changes Jan 17, 2024

View reviewed changes

mkg20001 merged commit f666630 into NixOS:master Jan 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

pgadmin: 8.1 -> 8.2, python3Packages.webauthn 1.11.1 -> 2.0.0, python3Packages.flask-security-too: fix pydantic issue#280556

pgadmin: 8.1 -> 8.2, python3Packages.webauthn 1.11.1 -> 2.0.0, python3Packages.flask-security-too: fix pydantic issue#280556
mkg20001 merged 3 commits intoNixOS:masterfrom
gador:pgadmin-8.2

gador commented Jan 12, 2024 •

edited

Loading

Uh oh!

mkg20001 commented Jan 12, 2024

Uh oh!

mkg20001 commented Jan 12, 2024

Uh oh!

gador commented Jan 12, 2024

Uh oh!

gador commented Jan 12, 2024

Uh oh!

gador commented Jan 12, 2024

Uh oh!

gador commented Jan 13, 2024

Uh oh!

gador commented Jan 13, 2024

Uh oh!

risicle commented Jan 13, 2024

Uh oh!

gador commented Jan 13, 2024

Uh oh!

gador commented Jan 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

gador commented Jan 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description of changes

Required changes to other packages

Things done

Uh oh!

mkg20001 commented Jan 12, 2024

Uh oh!

mkg20001 commented Jan 12, 2024

Uh oh!

gador commented Jan 12, 2024

Uh oh!

gador commented Jan 12, 2024

Uh oh!

gador commented Jan 12, 2024

Uh oh!

gador commented Jan 13, 2024

Uh oh!

gador commented Jan 13, 2024

Uh oh!

risicle commented Jan 13, 2024

Uh oh!

gador commented Jan 13, 2024

Uh oh!

gador commented Jan 13, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

gador commented Jan 12, 2024 •

edited

Loading